Allow equivalent plans when replacing#772
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 21, 2017
Merged
Conversation
Contributor
Author
|
Follow-up to #746 making it slightly more forgiving when replacing, should fix issues when dealing with complex catalogs/blueprints |
ahgittin
force-pushed
the
osgi-allow-equivalent-plans
branch
from
3f4188b to
56e3eec
Compare
geomacy
approved these changes
Jul 21, 2017
Contributor
geomacy
left a comment
geomacy
left a comment
There was a problem hiding this comment.
LGTM; will merge when test build succeeds
Contributor
|
test failure is real, in |
Contributor
|
It's just an update needed to the test expectations - there are now more tags than before on the result: |
with test case that fails without the equivalent plan checks, but works with them
ahgittin
force-pushed
the
osgi-allow-equivalent-plans
branch
from
56e3eec to
bb9d1f8
Compare
Contributor
Author
|
thanks @geomacy - fixed and merged |
Graeme-Miller
pushed a commit
to Graeme-Miller/brooklyn-server
that referenced
this pull request
Aug 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed because our routines sometimes rewrite the plan